beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5036) Optimize FileBasedSink's WriteOperation.moveToOutput()
Date Fri, 21 Sep 2018 18:01:01 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=146503&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146503
]

ASF GitHub Bot logged work on BEAM-5036:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 18:00
            Start Date: 21/Sep/18 18:00
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #6289: [BEAM-5036] Optimize the FileBasedSink
WriteOperation.moveToOutput()
URL: https://github.com/apache/beam/pull/6289#issuecomment-423622691
 
 
   What we are trying to say is that FileSystems will have a convenient and
   nice interface that does the right thing yet each FileSystem will have an
   arbitrary and/or overly complex interface. If we have users only relying on
   using FileSystems, why do we need that complexity within FileSystem
   implementations?
   
   On Thu, Sep 20, 2018 at 12:46 PM Tim Robertson <notifications@github.com>
   wrote:
   
   > Thanks everyone.
   >
   > @chamikaramj <https://github.com/chamikaramj> - if we are to correctly
   > support an OVERWRITE_EXISTING_FILES flag I think we'd either have to pass
   > the flag down into the filesystem implementations themselves, or do like
   > the HDFS one does now and always throw FileAlreadyExistsException (note a
   > user reports that issue today on user@ with AvroIO and LocalFileSystem)
   > when the target is in place. The later would require some of them to do a
   > "does target exist" check before attempting the move. Do you have a
   > preference on that?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/6289#issuecomment-423309448>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/AJnK7OIo-UAHqH6UokdDFhpr5hkV6BM2ks5uc_CagaJpZM4WQHrB>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146503)
    Time Spent: 3h 20m  (was: 3h 10m)

> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
>                 Key: BEAM-5036
>                 URL: https://issues.apache.org/jira/browse/BEAM-5036
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-files
>    Affects Versions: 2.5.0
>            Reporter: Jozef Vilcek
>            Assignee: Tim Robertson
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by copy+delete.
It would be better to use a rename() which can be much more effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this for the
case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaKnuPZD_qdh_QDm9VXLLsZw@mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message