beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5107) Support ES 6.x for ElasticsearchIO
Date Mon, 03 Sep 2018 08:47:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=140494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140494
]

ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/18 08:46
            Start Date: 03/Sep/18 08:46
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on a change in pull request #6211: [BEAM-5107]
Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#discussion_r214615302
 
 

 ##########
 File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOIT.java
 ##########
 @@ -93,24 +86,7 @@ public static void afterClass() throws Exception {
 
   @Test
   public void testSplitsVolume() throws Exception {
 
 Review comment:
   Hi @dattran-vn01 to solve your rebase issue:
   1. checkout master branch to local and update it (pull --rebase) to the latest commits
   2. create a new local branch from master : checkout -b BEAM-5107-ES6
   3. cherry pick the commits you did on branch BEAM-5107-Support-ES-6.x-for-ElasticsearchIO
to the new BEAM-5107-ES6 branch. You can cherry pick using Intellij: select the commits in
git log history window of branch BEAM-5107-Support-ES-6.x-for-ElasticsearchIO and right-click
cherry pick option. It will commit the cherry picked commits to the current branch  (BEAM-5107-ES6).
Don't forget to remove the "cherry picked from ..." comment in git comment.
   4. force push your branch BEAM-5107-ES6 to the remote branch BEAM-5107-Support-ES-6.x-for-ElasticsearchIO
to overwrite it.
   That way we keep review history and we can close your other PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 140494)
    Time Spent: 9h 20m  (was: 9h 10m)

> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
>                 Key: BEAM-5107
>                 URL: https://issues.apache.org/jira/browse/BEAM-5107
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Dat Tran
>            Assignee: Etienne Chauchot
>            Priority: Major
>          Time Spent: 9h 20m
>  Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message