beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5299) Define max global window as a shared value in protos like URN enums.
Date Tue, 18 Sep 2018 15:33:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=145326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145326
]

ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Sep/18 15:32
            Start Date: 18/Sep/18 15:32
    Worklog Time Spent: 10m 
      Work Description: ryan-williams commented on a change in pull request #6381: [BEAM-5299]
Define max timestamp for global window in proto
URL: https://github.com/apache/beam/pull/6381#discussion_r218482420
 
 

 ##########
 File path: sdks/java/core/build.gradle
 ##########
 @@ -51,6 +51,8 @@ test {
 }
 
 dependencies {
+  // Required to loads constants from the model, e.g. max timestamp for global window
+  shadow project(path: ":beam-model-pipeline", configuration: "shadow")
 
 Review comment:
   is the dependency being added here just to pick up the constant you've added?
   
   or did java-core already have this dependency, but was (incorrectly) not making that explicit
in its build.gradle (and picking it up transitively some other way)?
   
   If it's the former, I am j/w if putting the constant in a proto designed for more "core"
things would be better (answer could still be "that's not worth the overhead even though the
dep graph would be a bit more logical")

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145326)
    Time Spent: 1h 10m  (was: 1h)

> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
>                 Key: BEAM-5299
>                 URL: https://issues.apache.org/jira/browse/BEAM-5299
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
>            Reporter: Luke Cwik
>            Assignee: Maximilian Michels
>            Priority: Minor
>              Labels: portability
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the max timestamps
within proto to be shared across different languages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message