beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-5299) Define max global window as a shared value in protos like URN enums.
Date Thu, 20 Sep 2018 17:42:00 GMT


ASF GitHub Bot logged work on BEAM-5299:

                Author: ASF GitHub Bot
            Created on: 20/Sep/18 17:41
            Start Date: 20/Sep/18 17:41
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #6381: [BEAM-5299]
Define max timestamp for global window in proto

 File path: model/pipeline/src/main/proto/beam_runner_api.proto
 @@ -32,6 +32,20 @@ option java_outer_classname = "RunnerApi";
 import "google/protobuf/any.proto";
 import "google/protobuf/descriptor.proto";
+message BeamConstants {
+  enum Constants {
+    // The maximum timestamp for the global window in milliseconds since Jan 1, 1970.
+    // Triggers use maxTimestamp to set timers' timestamp. Timers fires when
+    // the watermark passes their timestamps. So, the timestamp needs to be
+    // smaller than the TIMESTAMP_MAX_MILLIS.
+    // One standard day is subtracted from TIMESTAMP_MAX_VALUE to make sure
+    // the maxTimestamp is smaller than TIMESTAMP_MAX_VALUE even after rounding up
+    // to seconds or minutes. See also GlobalWindow in the Java SDK.
+    // Value is represented in hex.
+    GLOBAL_WINDOW_MAX_TIMESTAMP_MILLIS = 0 [(beam_constant) = "20c49ba0bcf7f7"];
 Review comment:
   @robertwb Hex doesn't seemed to have helped the readability here, can we stick with a number
base 10?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 146079)
    Time Spent: 2.5h  (was: 2h 20m)

> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>                 Key: BEAM-5299
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
>            Reporter: Luke Cwik
>            Assignee: Maximilian Michels
>            Priority: Minor
>              Labels: portability
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
> Instead of having each language define a max timestamp themselves, define the max timestamps
within proto to be shared across different languages.

This message was sent by Atlassian JIRA

View raw message