beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5317) Finish Python 3 porting for options module
Date Fri, 14 Sep 2018 22:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5317?focusedWorklogId=144494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144494
]

ASF GitHub Bot logged work on BEAM-5317:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Sep/18 22:56
            Start Date: 14/Sep/18 22:56
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #6397: [BEAM-5317]
Finish Python3 porting for options module
URL: https://github.com/apache/beam/pull/6397#discussion_r217860728
 
 

 ##########
 File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
 ##########
 @@ -329,7 +329,11 @@ def get_validator(matcher):
     ]
 
     for case in test_case:
-      errors = get_validator(case['on_success_matcher']).validate()
+      matcher = case['on_success_matcher']
+      if matcher and type(matcher) is bytes:
+        errors = get_validator(matcher.decode('utf-8')).validate()
 
 Review comment:
   I think I would instead change line 315 to:
   ```
   options.append('%s=%s' % ('--on_success_matcher=' , matcher.decode()))
   ```
   line 155 in test_pipeline.py to: 
   ```
   options.append('--%s=%s' % (k, pickler.dumps(v).decode()))
   ```
   and change `abc` to `b'abc'` in one of the test cases.
   
   What do you all think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144494)
    Time Spent: 3h  (was: 2h 50m)

> Finish Python 3 porting for options module
> ------------------------------------------
>
>                 Key: BEAM-5317
>                 URL: https://issues.apache.org/jira/browse/BEAM-5317
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Manu Zhang
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message