beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5324) Finish Python 3 porting for unpackaged files
Date Tue, 18 Sep 2018 18:13:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5324?focusedWorklogId=145414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145414
]

ASF GitHub Bot logged work on BEAM-5324:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Sep/18 18:12
            Start Date: 18/Sep/18 18:12
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #6424: [BEAM-5324]
Partially port unpackaged modules to Python 3
URL: https://github.com/apache/beam/pull/6424#discussion_r218536804
 
 

 ##########
 File path: sdks/python/apache_beam/runners/runner.py
 ##########
 @@ -96,7 +96,7 @@ def create_runner(runner_name):
   if '.' in runner_name:
     module, runner = runner_name.rsplit('.', 1)
     try:
-      return getattr(__import__(module, {}, {}, [runner], -1), runner)()
+      return getattr(__import__(module, {}, {}, [runner], 0), runner)()
 
 Review comment:
   A note for other reviewers from `__import__` documentation:
   
   > level specifies whether to use absolute or relative imports. The default is -1 which
indicates both absolute and relative imports will be attempted. 0 means only perform absolute
imports. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145414)
    Time Spent: 0.5h  (was: 20m)

> Finish Python 3 porting for unpackaged files
> --------------------------------------------
>
>                 Key: BEAM-5324
>                 URL: https://issues.apache.org/jira/browse/BEAM-5324
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message