beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5324) Finish Python 3 porting for unpackaged files
Date Thu, 20 Sep 2018 00:48:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5324?focusedWorklogId=145889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145889
]

ASF GitHub Bot logged work on BEAM-5324:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Sep/18 00:47
            Start Date: 20/Sep/18 00:47
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #6424: [BEAM-5324]
Partially port unpackaged modules to Python 3
URL: https://github.com/apache/beam/pull/6424#discussion_r219006409
 
 

 ##########
 File path: sdks/python/apache_beam/runners/runner.py
 ##########
 @@ -96,7 +96,7 @@ def create_runner(runner_name):
   if '.' in runner_name:
     module, runner = runner_name.rsplit('.', 1)
     try:
-      return getattr(__import__(module, {}, {}, [runner], -1), runner)()
+      return getattr(__import__(module, {}, {}, [runner], 0), runner)()
 
 Review comment:
   I think the reason is the same as why we add `from __future__ import absolute_import` elsewhere
- to explicitly disable implicit intra-package import behavior in Python 2 for forward-compatibility
with Python 3. @RobbeSneyders, were some tests affected by this?
   
   Related:
   http://python-future.org/imports.html
   https://www.python.org/dev/peps/pep-0302/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145889)
    Time Spent: 2h 10m  (was: 2h)

> Finish Python 3 porting for unpackaged files
> --------------------------------------------
>
>                 Key: BEAM-5324
>                 URL: https://issues.apache.org/jira/browse/BEAM-5324
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message