beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5337) [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] Build times out in beam-runners-flink target
Date Fri, 14 Sep 2018 07:23:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=144199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144199
]

ASF GitHub Bot logged work on BEAM-5337:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Sep/18 07:22
            Start Date: 14/Sep/18 07:22
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #6385: [BEAM-5337] Fix flaky
test UnboundedSourceWrapperTest#testValueEmission
URL: https://github.com/apache/beam/pull/6385#discussion_r217621228
 
 

 ##########
 File path: runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java
 ##########
 @@ -187,10 +188,9 @@ public void collect(
                 @Override
                 public void close() {}
               });
-        } catch (SuccessException e) {
+        } finally {
           processingTimeUpdateThread.interrupt();
 
 Review comment:
   The thread doesn't have to be sleeping to get interrupted. It is enough for the interrupt
flag to be set via `processingTimeUpdateThread.interrupt();` for the thread to throw an `InterruptedException`
the next time it attempts to sleep. You can test that easily, e.g.
   
   ```java
       new Thread(new Runnable() {
         @Override
         public void run() {
          Thread.currentThread().interrupt();
           try {
             Thread.sleep(1000);
           } catch (InterruptedException e) {
             System.out.println("interrupted");
           }
         }
       }).start();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144199)
    Time Spent: 1h 10m  (was: 1h)

> [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] Build times
out in beam-runners-flink target
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-5337
>                 URL: https://issues.apache.org/jira/browse/BEAM-5337
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink, test-failures
>            Reporter: Mikhail Gryzykhin
>            Assignee: Maximilian Michels
>            Priority: Critical
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Job times out. 
>  Failing job url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/consoleFull]
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/consoleFull]
> https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/consoleFull
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message