beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5357) Go check for IsWorkerCompatibleBinary is wrong
Date Tue, 11 Sep 2018 19:46:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5357?focusedWorklogId=143253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-143253
]

ASF GitHub Bot logged work on BEAM-5357:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Sep/18 19:45
            Start Date: 11/Sep/18 19:45
    Worklog Time Spent: 10m 
      Work Description: herohde closed pull request #6363: [BEAM-5357] Disable optimization
for Go check IsWorkerCompatibleBinary
URL: https://github.com/apache/beam/pull/6363
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go b/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go
index 1dae66e1442..ecf5c1b4ab6 100644
--- a/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go
+++ b/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go
@@ -35,9 +35,6 @@ import (
 // IsWorkerCompatibleBinary returns the path to itself and true if running
 // a linux-amd64 binary that can directly be used as a worker binary.
 func IsWorkerCompatibleBinary() (string, bool) {
-	if runtime.GOOS == "linux" && runtime.GOARCH == "amd64" {
-		return os.Args[0], true
-	}
 	return "", false
 }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 143253)
    Time Spent: 20m  (was: 10m)

> Go check for IsWorkerCompatibleBinary is wrong
> ----------------------------------------------
>
>                 Key: BEAM-5357
>                 URL: https://issues.apache.org/jira/browse/BEAM-5357
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Robert Burke
>            Priority: Critical
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Per BEAM-5253, The linux/amd64 check in IsWorkerCompatibleBinary is insufficient:
> https://github.com/apache/beam/blob/609a42978405173a60e5d91f35170a5c0b5d5332/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go#L37
> We need to see if we can do a better check here (such as looking up the symbol table
or similar) or disable this optimization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message