beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5375) KafkaIO reader should handle runtime exceptions kafka client
Date Thu, 13 Sep 2018 20:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5375?focusedWorklogId=144073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144073
]

ASF GitHub Bot logged work on BEAM-5375:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/18 20:56
            Start Date: 13/Sep/18 20:56
    Worklog Time Spent: 10m 
      Work Description: rangadi commented on a change in pull request #6391: [BEAM-5375] KafkaIO
: Handle runtime exceptions while fetching from Kafka better. 
URL: https://github.com/apache/beam/pull/6391#discussion_r217531315
 
 

 ##########
 File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java
 ##########
 @@ -570,28 +570,33 @@ Instant updateAndGetWatermark() {
   private void consumerPollLoop() {
     // Read in a loop and enqueue the batch of records, if any, to availableRecordsQueue.
 
-    ConsumerRecords<byte[], byte[]> records = ConsumerRecords.empty();
-    while (!closed.get()) {
 
 Review comment:
   Quick note: Nothing has changed inside the while loop. The whole block placed under another
try-catch clause. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144073)
    Time Spent: 0.5h  (was: 20m)

> KafkaIO reader should handle runtime exceptions kafka client
> ------------------------------------------------------------
>
>                 Key: BEAM-5375
>                 URL: https://issues.apache.org/jira/browse/BEAM-5375
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-kafka
>    Affects Versions: 2.7.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> KafkaIO reader might stop reading from Kafka without any explicit error message if KafkaConsumer
throws a runtime exception while polling for messages. One of the Dataflow customers encountered
this issue (see [user@ thread|[https://lists.apache.org/thread.html/c0cf8f45f567a0623592e2d8340f5288e3e774b59bca985aec410a81@%3Cuser.beam.apache.org%3E])]
> 'consumerPollThread()' in KafkaIO deliberately avoided catching runtime exceptions. It
shoud handle it.. stuff happens at runtime. 
> It should result in 'IOException' from start()/advance(). The runners will handle properly
reporting and closing the readers. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message