beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5376) Row interface doesn't support nullability on all fields.
Date Wed, 12 Sep 2018 23:14:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5376?focusedWorklogId=143811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-143811
]

ASF GitHub Bot logged work on BEAM-5376:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/18 23:13
            Start Date: 12/Sep/18 23:13
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #6383: [BEAM-5376]
Support nullability on all Row types
URL: https://github.com/apache/beam/pull/6383#discussion_r217217788
 
 

 ##########
 File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/JavaBeanSchemaTest.java
 ##########
 @@ -155,10 +155,10 @@ public void testRecursiveGetters() throws NoSuchSchemaException {
 
     Row nestedRow = row.getRow("nested");
     assertEquals("string", nestedRow.getString("str"));
-    assertEquals((byte) 1, nestedRow.getByte("aByte"));
-    assertEquals((short) 2, nestedRow.getInt16("aShort"));
-    assertEquals((int) 3, nestedRow.getInt32("anInt"));
-    assertEquals((long) 4, nestedRow.getInt64("aLong"));
+    assertEquals((byte) 1, (Object) nestedRow.getByte("aByte"));
 
 Review comment:
   1. Because you can't cast a constant directly to `(Byte)` in java 8.
   2. Because I want to make sure getByte is returning the `Byte` type as part of this test
and not just something that can promote to `Byte`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 143811)
    Time Spent: 40m  (was: 0.5h)

> Row interface doesn't support nullability on all fields.
> --------------------------------------------------------
>
>                 Key: BEAM-5376
>                 URL: https://issues.apache.org/jira/browse/BEAM-5376
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> For example: 
> {code:java}
> public boolean getBoolean(int idx);{code}
> Should be:
> {code:java}
> public Boolean getBoolean(int idx);{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message