beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5427) Fix sample code (AverageFn) in Combine.java
Date Fri, 21 Sep 2018 18:12:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5427?focusedWorklogId=146518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146518
]

ASF GitHub Bot logged work on BEAM-5427:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 18:11
            Start Date: 21/Sep/18 18:11
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on a change in pull request #6439: [BEAM-5427]
Fix and update sample code for CombineFn.
URL: https://github.com/apache/beam/pull/6439#discussion_r219577690
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
 ##########
 @@ -254,10 +254,26 @@ private Combine() {
    *
    * <pre>{@code
    * public class AverageFn extends CombineFn<Integer, AverageFn.Accum, Double> {
-   *   public static class Accum {
+   *   public static class Accum implements java.io.Serializable {
    *     int sum = 0;
    *     int count = 0;
+   *
+   *     {@literal @}Override
 
 Review comment:
   The \@literal tag shouldn't have those braces around it. It should look like this:
   
   `@literal @Override`
   
   One detail is that doing it that way will also display an extra space before the @Override,
so make sure to move the line back one space. If you're using IntelliJ you can easily see
what I mean by clicking on CombineFn and pressing Ctrl+Q to bring up the Quick Documentation
window, which renders this javadoc comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146518)

> Fix sample code (AverageFn) in Combine.java
> -------------------------------------------
>
>                 Key: BEAM-5427
>                 URL: https://issues.apache.org/jira/browse/BEAM-5427
>             Project: Beam
>          Issue Type: Improvement
>          Components: examples-java
>            Reporter: Ruoyun Huang
>            Assignee: Ruoyun Huang
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Sample code missing coder. 
> In its current state, job run fails with Coder missing error. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message