beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5430) Adjust implementation of CombineGroupedValues runner to use CombineFn.apply
Date Thu, 20 Sep 2018 22:24:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5430?focusedWorklogId=146150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146150
]

ASF GitHub Bot logged work on BEAM-5430:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Sep/18 22:23
            Start Date: 20/Sep/18 22:23
    Worklog Time Spent: 10m 
      Work Description: HuangLED commented on issue #6454: [BEAM-5430] Adjust implementation
of CombineGroupedValues runner to use CombineFn.apply
URL: https://github.com/apache/beam/pull/6454#issuecomment-423353670
 
 
   @youngoli 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146150)
    Time Spent: 20m  (was: 10m)

> Adjust implementation of CombineGroupedValues runner to use CombineFn.apply
> ---------------------------------------------------------------------------
>
>                 Key: BEAM-5430
>                 URL: https://issues.apache.org/jira/browse/BEAM-5430
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-harness
>            Reporter: Daniel Oliveira
>            Assignee: Ruoyun Huang
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In the [implementation for the runner of Combine.GroupedValues|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java#L217]
in the Java SDK it essentially re-implements what was already implemented in [CombineFn.apply|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java#L348].
> The implementation should instead just call CombineFn.apply for simplicity and code reuse.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message