beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5442) PortableRunner swallows custom options for Runner
Date Fri, 21 Sep 2018 10:41:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=146322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146322
]

ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 10:40
            Start Date: 21/Sep/18 10:40
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #6447: [BEAM-5442]
Add FlinkOptions to Python SDK
URL: https://github.com/apache/beam/pull/6447#discussion_r219453499
 
 

 ##########
 File path: sdks/python/apache_beam/options/pipeline_options.py
 ##########
 @@ -662,6 +662,23 @@ def _add_argparse_args(cls, parser):
                          'in the pipeline when running using the Fn API.'))
 
 
+class FlinkOptions(PipelineOptions):
 
 Review comment:
   Yeah, I guess it doesn't make it any worse. (The way we do things here has always felt
slightly unpythonic to me, but cleaning this up is low on the priority list...)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146322)
    Time Spent: 1.5h  (was: 1h 20m)

> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
>                 Key: BEAM-5442
>                 URL: https://issues.apache.org/jira/browse/BEAM-5442
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability, portability-flink
>             Fix For: 2.8.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the PortableRunner.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message