beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-5442) PortableRunner swallows custom options for Runner
Date Fri, 21 Sep 2018 10:47:00 GMT


ASF GitHub Bot logged work on BEAM-5442:

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 10:46
            Start Date: 21/Sep/18 10:46
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #6447: [BEAM-5442] Add FlinkOptions
to Python SDK

 File path: sdks/python/apache_beam/options/
 @@ -662,6 +662,23 @@ def _add_argparse_args(cls, parser):
                          'in the pipeline when running using the Fn API.'))
+class FlinkOptions(PipelineOptions):
+  @classmethod
+  def _add_argparse_args(cls, parser):
+    parser.add_argument('--flink_master',
+                        type=str,
+                        help=
+                        ('Addres of the Flink master where the Pipeline '
+                         'should be executed. Can either be of the form '
+                         '\'host:port\' or one of the special values '
+                         '[local], [collection], or [auto].'))
+    parser.add_argument('--parallelism',
 Review comment:
   The problem here is that we want to stay consistent with `FlinkPipelineOptions`, so I'd
keep it as it is to not introduce a source of confusion.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 146325)
    Time Spent: 1h 40m  (was: 1.5h)

> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>                 Key: BEAM-5442
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability, portability-flink
>             Fix For: 2.8.0
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
> The PortableRunner doesn't pass custom PipelineOptions to the executing Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the PortableRunner.

This message was sent by Atlassian JIRA

View raw message