beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5443) Simplify Python pipeline options for portable runner
Date Thu, 27 Sep 2018 23:04:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5443?focusedWorklogId=148936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148936
]

ASF GitHub Bot logged work on BEAM-5443:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Sep/18 23:03
            Start Date: 27/Sep/18 23:03
    Worklog Time Spent: 10m 
      Work Description: angoenka commented on a change in pull request #6512: [BEAM-5443]
Pipeline option defaults for portable runner.
URL: https://github.com/apache/beam/pull/6512#discussion_r221102810
 
 

 ##########
 File path: sdks/python/apache_beam/pipeline.py
 ##########
 @@ -152,6 +153,12 @@ def __init__(self, runner=None, options=None, argv=None):
       raise ValueError(
           'Pipeline has validations errors: \n' + '\n'.join(errors))
 
+    # set default experiments for portable runner
+    # (needs to occur prior to pipeline construction)
+    if self._options.view_as(StandardOptions).runner == 'PortableRunner':
+      self._options.view_as(DebugOptions).experiments = (
+            self._options.view_as(DebugOptions).experiments or ['beam_fn_api'])
 
 Review comment:
   I think it should be ok to add beam_fn_api always as without it the pipeline will fail.

   And the behavior will be inconsistent where when no experiment is provided then the pipeline
works but when when experiments is provided without explicit beam_fn_api, the pipeline fails.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 148936)
    Time Spent: 1h  (was: 50m)

> Simplify Python pipeline options for portable runner
> ----------------------------------------------------
>
>                 Key: BEAM-5443
>                 URL: https://issues.apache.org/jira/browse/BEAM-5443
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-harness
>    Affects Versions: 2.7.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Major
>              Labels: portability
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, the user needs to specify several extra pipeline options to run a Python pipeline
with the portable runner. It would be nice to remove the need to explicitly provide these
options when they can be inferred / have defaults.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message