beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5458) Python PreCommit broken
Date Fri, 21 Sep 2018 20:31:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5458?focusedWorklogId=146579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146579
]

ASF GitHub Bot logged work on BEAM-5458:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 20:30
            Start Date: 21/Sep/18 20:30
    Worklog Time Spent: 10m 
      Work Description: udim commented on issue #6465: [BEAM-5458] Fix python tests
URL: https://github.com/apache/beam/pull/6465#issuecomment-423661843
 
 
   I think the issue is that the Hamcrest docs website is an external dependency:
   https://github.com/apache/beam/blob/da9432b197207ab39edc6cb720286a81153b6d3b/sdks/python/scripts/generate_pydoc.sh#L116
   
   Compare:
   https://pyhamcrest.readthedocs.io/en/latest/core/ (empty)
   with:
   https://pyhamcrest.readthedocs.io/en/v1.9.0/core/
   
   I suggest changing the above line to:
   ```
     'hamcrest': ('https://pyhamcrest.readthedocs.io/en/stable/', None),
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146579)
    Time Spent: 40m  (was: 0.5h)

> Python PreCommit broken
> -----------------------
>
>                 Key: BEAM-5458
>                 URL: https://issues.apache.org/jira/browse/BEAM-5458
>             Project: Beam
>          Issue Type: Test
>          Components: test-failures, testing
>            Reporter: Maximilian Michels
>            Priority: Critical
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Python PreCommit is currently broken:
> https://builds.apache.org/job/beam_PreCommit_Python_Commit/1308/#showFailuresLink



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message