beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5458) Python PreCommit broken
Date Fri, 21 Sep 2018 21:23:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5458?focusedWorklogId=146601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146601
]

ASF GitHub Bot logged work on BEAM-5458:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 21:22
            Start Date: 21/Sep/18 21:22
    Worklog Time Spent: 10m 
      Work Description: tweise closed pull request #6465: [BEAM-5458] Fix python tests
URL: https://github.com/apache/beam/pull/6465
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/apache_beam/runners/portability/fn_api_runner.py b/sdks/python/apache_beam/runners/portability/fn_api_runner.py
index 32d7adef068..4b8e6dabbc0 100644
--- a/sdks/python/apache_beam/runners/portability/fn_api_runner.py
+++ b/sdks/python/apache_beam/runners/portability/fn_api_runner.py
@@ -63,9 +63,9 @@
 ENCODED_IMPULSE_VALUE = beam.coders.WindowedValueCoder(
     beam.coders.BytesCoder(),
     beam.coders.coders.GlobalWindowCoder()).get_impl().encode_nested(
-        beam.transforms.window.GlobalWindows.windowed_value(''))
+        beam.transforms.window.GlobalWindows.windowed_value(b''))
 
-IMPULSE_BUFFER_PREFIX = 'impulse:'
+IMPULSE_BUFFER_PREFIX = b'impulse:'
 
 
 class BeamFnControlServicer(beam_fn_api_pb2_grpc.BeamFnControlServicer):
@@ -456,7 +456,8 @@ def impulse_to_input(stages):
                     unique_name=transform.unique_name,
                     spec=beam_runner_api_pb2.FunctionSpec(
                         urn=bundle_processor.DATA_INPUT_URN,
-                        payload=str(IMPULSE_BUFFER_PREFIX + impulse_pc)),
+                        payload=IMPULSE_BUFFER_PREFIX +
+                        impulse_pc.encode('utf-8')),
                     outputs=transform.outputs))
 
         yield stage
diff --git a/sdks/python/scripts/generate_pydoc.sh b/sdks/python/scripts/generate_pydoc.sh
index 2f6f0f14cfb..e9b5c812736 100755
--- a/sdks/python/scripts/generate_pydoc.sh
+++ b/sdks/python/scripts/generate_pydoc.sh
@@ -113,7 +113,7 @@ import apache_beam as beam
 
 intersphinx_mapping = {
   'python': ('https://docs.python.org/2', None),
-  'hamcrest': ('https://pyhamcrest.readthedocs.io/en/latest/', None),
+  'hamcrest': ('https://pyhamcrest.readthedocs.io/en/stable/', None),
 }
 
 # Since private classes are skipped by sphinx, if there is any cross reference


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146601)
    Time Spent: 1h  (was: 50m)

> Python PreCommit broken
> -----------------------
>
>                 Key: BEAM-5458
>                 URL: https://issues.apache.org/jira/browse/BEAM-5458
>             Project: Beam
>          Issue Type: Test
>          Components: test-failures, testing
>            Reporter: Maximilian Michels
>            Priority: Critical
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Python PreCommit is currently broken:
> https://builds.apache.org/job/beam_PreCommit_Python_Commit/1308/#showFailuresLink



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message