From commits-return-90833-apmail-beam-commits-archive=beam.apache.org@beam.apache.org Wed Sep 5 15:28:03 2018 Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC4191DC16 for ; Wed, 5 Sep 2018 15:28:03 +0000 (UTC) Received: (qmail 7857 invoked by uid 500); 5 Sep 2018 15:28:02 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 7697 invoked by uid 500); 5 Sep 2018 15:28:02 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 7687 invoked by uid 99); 5 Sep 2018 15:28:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 15:28:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 56717C1EED for ; Wed, 5 Sep 2018 15:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Z1p9xrl6aquG for ; Wed, 5 Sep 2018 15:28:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5F1FC5F3F4 for ; Wed, 5 Sep 2018 15:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9EEEFE02EB for ; Wed, 5 Sep 2018 15:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 41A5226B56 for ; Wed, 5 Sep 2018 15:28:00 +0000 (UTC) Date: Wed, 5 Sep 2018 15:28:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4511) Create a tox environment that uses Py3 interpreter for pre/post commit test suites, once codebase supports Py3. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4511?focusedWorklogId=141328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141328 ] ASF GitHub Bot logged work on BEAM-4511: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Sep/18 15:27 Start Date: 05/Sep/18 15:27 Worklog Time Spent: 10m Work Description: aaltay commented on a change in pull request #6266: [BEAM-4511] added py3 tox env for first test URL: https://github.com/apache/beam/pull/6266#discussion_r215317938 ########## File path: sdks/python/gen_protos.py ########## @@ -110,14 +112,17 @@ def generate_proto_files(force=False): 'Protoc returned non-zero status (see logs for details): ' '%s' % ret_code) - if sys.version_info[0] >= 3: - ret_code = subprocess.call( - ["futurize", "--both-stages", "--write", "--verbose", "--no-diff", - out_dir]) + ret_code = subprocess.call(["pip", "install", "future==0.16.0"]) Review comment: (unrelated to python3 and this pr). Could we convert gen_protos to tox task and control its environment that way including installing grpcio and future? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 141328) Time Spent: 1h 40m (was: 1.5h) > Create a tox environment that uses Py3 interpreter for pre/post commit test suites, once codebase supports Py3. > ---------------------------------------------------------------------------------------------------------------- > > Key: BEAM-4511 > URL: https://issues.apache.org/jira/browse/BEAM-4511 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Valentyn Tymofieiev > Assignee: Matthias Feys > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)