beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pabl...@apache.org
Subject [beam] branch master updated: [BEAM-6611] Move limitations comment to TriggerCopyJobs
Date Thu, 01 Aug 2019 22:18:39 GMT
This is an automated email from the ASF dual-hosted git repository.

pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 7c51e13  [BEAM-6611] Move limitations comment to TriggerCopyJobs
     new 2129c31  Merge pull request #9216 from ttanay/bq-copy-comment
7c51e13 is described below

commit 7c51e13c19987039f2adb4c32984c3299c5554f0
Author: ttanay <ttanay100@gmail.com>
AuthorDate: Thu Aug 1 23:26:41 2019 +0530

    [BEAM-6611] Move limitations comment to TriggerCopyJobs
---
 sdks/python/apache_beam/io/gcp/bigquery.py            | 5 -----
 sdks/python/apache_beam/io/gcp/bigquery_file_loads.py | 4 ++++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/sdks/python/apache_beam/io/gcp/bigquery.py b/sdks/python/apache_beam/io/gcp/bigquery.py
index facbf9c..4f0a762 100644
--- a/sdks/python/apache_beam/io/gcp/bigquery.py
+++ b/sdks/python/apache_beam/io/gcp/bigquery.py
@@ -895,11 +895,6 @@ class WriteToBigQuery(PTransform):
   This transform receives a PCollection of elements to be inserted into BigQuery
   tables. The elements would come in as Python dictionaries, or as `TableRow`
   instances.
-
-  Known Limitations/Edge Cases:
-    1. [BEAM-7822] In file loads method of writing to BigQuery,
-       copying from temp_tables to destination_table is not atomic.
-       See: https://issues.apache.org/jira/browse/BEAM-7822
   """
 
   class Method(object):
diff --git a/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py b/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py
index a6871cd..b5b7c19 100644
--- a/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py
+++ b/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py
@@ -268,6 +268,10 @@ class TriggerCopyJobs(beam.DoFn):
   destination tables.
 
   This transform emits (destination, job_reference) pairs.
+
+  TODO(BEAM-7822): In file loads method of writing to BigQuery,
+    copying from temp_tables to destination_table is not atomic.
+    See: https://issues.apache.org/jira/browse/BEAM-7822
   """
   def __init__(self,
                create_disposition=None,


Mime
View raw message