beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes
Date Wed, 26 Feb 2020 19:05:14 GMT
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes
URL: https://github.com/apache/beam/pull/10822#discussion_r384700835
 
 

 ##########
 File path: sdks/python/apache_beam/runners/common.py
 ##########
 @@ -375,7 +379,7 @@ class DoFnInvoker(object):
   represented by a given DoFnSignature."""
 
   def __init__(self,
-               output_processor,  # type: OutputProcessor
+               output_processor,  # type: _OutputProcessor
 
 Review comment:
   hmmm... well, at the time that I made this change I _think_ it resolved an error, but either
I am mistaken or something changed in the module.   I'm rolling this back. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message