beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property.
Date Wed, 26 Feb 2020 19:11:25 GMT
lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from
runner_api include the output_tags property.
URL: https://github.com/apache/beam/pull/10892#discussion_r384698347
 
 

 ##########
 File path: sdks/python/apache_beam/testing/test_stream.py
 ##########
 @@ -133,15 +140,21 @@ def __eq__(self, other):
     return self.new_watermark == other.new_watermark and self.tag == other.tag
 
   def __hash__(self):
-    return hash(self.new_watermark)
+    return hash(str(self.new_watermark) + str(self.tag))
 
   def __lt__(self, other):
     return self.new_watermark < other.new_watermark
 
   def to_runner_api(self, unused_element_coder):
+    tag = 'None' if self.tag is None else self.tag
+
+    # Assert that no prevision is lost.
 
 Review comment:
   ```suggestion
       # Assert that no precision is lost.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message