beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] lukecwik commented on a change in pull request #10980: Address leftover styling comments from PR/10892
Date Wed, 26 Feb 2020 21:10:17 GMT
lukecwik commented on a change in pull request #10980: Address leftover styling comments from
PR/10892
URL: https://github.com/apache/beam/pull/10980#discussion_r384766435
 
 

 ##########
 File path: sdks/python/apache_beam/testing/test_stream.py
 ##########
 @@ -183,9 +182,20 @@ class TestStream(PTransform):
   Each event emits elements, advances the watermark or advances the processing
   time. After all of the specified elements are emitted, ceases to produce
   output.
+
+  When expanded, if only the default output or only one output tag is specified,
+  then a PCollection will be returned. Otherwise, a dictionary of output names
+  to PCollection will be returned.
   """
   def __init__(
       self, coder=coders.FastPrimitivesCoder(), events=None, output_tags=None):
+    """
+    :param coder: The coder to encode/decode elements.
+    :param events: Events can be given and must be a subset of the output_tags.
+    :param output_tags: Can be specified to allow for adding outputs that
+                        produce no output.
 
 Review comment:
   ```suggestion
       :param coder: The coder to encode/decode elements.
       :param events: The initial set of events. If specified, the events tags must exist
in the output_tags.
       :param output_tags: Initial set of outputs. If no event references an output tag, no
output will be produced for that tag.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message