beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled
Date Wed, 26 Feb 2020 22:34:56 GMT
aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people,
setting the default to have the experiment be disabled
URL: https://github.com/apache/beam/pull/10934#discussion_r384809280
 
 

 ##########
 File path: sdks/python/apache_beam/pipeline.py
 ##########
 @@ -620,23 +620,25 @@ def apply(self, transform, pvalueish=None, label=None):
         current.add_output(result, result._main_tag)
         continue
 
+      # TODO(BEAM-9322): Remove the experiment check and have this conditional
+      # be the default.
+      if self._options.view_as(DebugOptions).lookup_experiment(
+          'passthrough_pcollection_output_ids', default=False):
+        # Otherwise default to the new implementation which only auto-generates
 
 Review comment:
   I think this comment could be improved, because this is not the otherwise case anymore.
Follow up PR would be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message