beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper
Date Wed, 26 Feb 2020 23:28:13 GMT
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF
wrapper
URL: https://github.com/apache/beam/pull/10897#discussion_r384793593
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
 ##########
 @@ -375,4 +422,361 @@ public void checkDone() throws IllegalStateException {
       }
     }
   }
+
+  /**
+   * A splittable {@link DoFn} which executes an {@link UnboundedSource}.
+   *
+   * <p>We model the element as the original source and the restriction as a pair of
the sub-source
+   * and its {@link CheckpointMark}. This allows us to split the sub-source over and over
as long as
+   * the checkpoint mark is {@code null} or the {@link NoopCheckpointMark} since it does
not
+   * maintain any state.
+   */
+  // TODO: Support reporting the watermark, currently the watermark never advances.
+  @UnboundedPerElement
+  static class UnboundedSourceAsSDFWrapperFn<OutputT, CheckpointT extends CheckpointMark>
+      extends DoFn<UnboundedSource<OutputT, CheckpointT>, ValueWithRecordId<OutputT>>
{
+
+    private static final int DEFAULT_DESIRED_NUM_SPLITS = 20;
 
 Review comment:
   It seems the risk is higher setting this too low than too high--maybe 100 or more? (Is
there a JIRA for letting the runner pass this in?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message