beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.
Date Thu, 27 Feb 2020 00:26:36 GMT
robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work
for different runners.
URL: https://github.com/apache/beam/pull/10951#discussion_r384848033
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/combiners_test.py
 ##########
 @@ -470,6 +470,9 @@ def test_combining_with_accumulation_mode_and_fanout(self):
       ts.add_elements([i])
     ts.advance_watermark_to_infinity()
 
+    def is_early_firing(element, num_partitions):
+      return 0 if element < 15 else 1
 
 Review comment:
   This was fixed last year. Looks like the bug was never closed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message