From dev-return-3528-apmail-bloodhound-dev-archive=bloodhound.apache.org@bloodhound.apache.org Mon Sep 16 20:32:02 2013 Return-Path: X-Original-To: apmail-bloodhound-dev-archive@www.apache.org Delivered-To: apmail-bloodhound-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14EC310D0A for ; Mon, 16 Sep 2013 20:32:02 +0000 (UTC) Received: (qmail 93294 invoked by uid 500); 16 Sep 2013 20:32:01 -0000 Delivered-To: apmail-bloodhound-dev-archive@bloodhound.apache.org Received: (qmail 93189 invoked by uid 500); 16 Sep 2013 20:31:56 -0000 Mailing-List: contact dev-help@bloodhound.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@bloodhound.apache.org Delivered-To: mailing list dev@bloodhound.apache.org Received: (qmail 93181 invoked by uid 99); 16 Sep 2013 20:31:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 20:31:54 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of antonia.horincar@gmail.com designates 209.85.160.53 as permitted sender) Received: from [209.85.160.53] (HELO mail-pb0-f53.google.com) (209.85.160.53) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 20:31:50 +0000 Received: by mail-pb0-f53.google.com with SMTP id up15so4569550pbc.12 for ; Mon, 16 Sep 2013 13:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=D4veMoaMOGtG+F3HALDivg6/StL2/dI9nBzeEXgpxNM=; b=VMM4F3LhOZcz1r7V8Bj8fuVw5su8qSG7C8fftESKixR2SQQVTmL1ApB/AjbCRMOut/ CVjtC4aT8f/CR2aG162gawGXTdyPgIm2ulCN0xMWX6+qs2GvUieVPyBKxKLnKbDko8Q5 ONa3GpBbx5Ns0633sKcnxUeyr+Y9LixcwNcECctT+mss9QaJ0Tt1hn0pDjhLufJ+CXDi UWLS/UbUV4PWcS8LZu6fJUEXhBG9IAuCxYpXuJI+Ml+He1mJatWbkVennDJD/gF+bIfa JGGYgXBXxZgoV64hFaHfLcsDN1zRZCPc4RF1j6li7mljd/nVchRKDqNlL2+NTYKQY2Yv 1lAg== MIME-Version: 1.0 X-Received: by 10.66.254.170 with SMTP id aj10mr4595202pad.142.1379363489919; Mon, 16 Sep 2013 13:31:29 -0700 (PDT) Received: by 10.70.101.7 with HTTP; Mon, 16 Sep 2013 13:31:29 -0700 (PDT) In-Reply-To: <44AFA6E2-6A76-4215-A117-D1E67DA5300B@digiverse.si> References: <44AFA6E2-6A76-4215-A117-D1E67DA5300B@digiverse.si> Date: Mon, 16 Sep 2013 23:31:29 +0300 Message-ID: Subject: Re: BEP-0007 Embeddable tickets - final two weeks From: Antonia Horincar To: dev@bloodhound.apache.org Content-Type: multipart/alternative; boundary=047d7b15b2fdd5387d04e686161d X-Virus-Checked: Checked by ClamAV on apache.org --047d7b15b2fdd5387d04e686161d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Thank you for your help. I managed to make this work for tickets and queries, but not for products and milestones. For milestones, I implemented the IRequestFilter interface in the trac.ticket.roadmap.MilestoneModule class. However, it seems that the value returned by self.env.config.getbool('components', 'bhembedding.*') is True regardless of the state of the plugin (enabled or disabled). Do you have any idea what could be the problem? I am not sure where should I implement IRequestFilter so that the embedding buttons on bhdashboard/layouts/templates/bs_grid_full.html and bhdashboard/widgets/templates/widget_product.html are showed only if the plugin is enabled. I tried implementing it in bhdashboard.web_ui.DashboardModule class, but from what I see the bhembedding value in data is not passed on to the templates. Thanks, Antonia On Wed, Sep 11, 2013 at 7:14 PM, Matev=C5=BE Brada=C4=8D wrote: > > On 11. Sep, 2013, at 13:49, Antonia Horincar wrote: > > > Hi Joe, > > > > > > On Tue, Sep 10, 2013 at 6:51 PM, Joachim Dreimann < > > joachim.dreimann@wandisco.com> wrote: > > > >> Hi Antonia (and everyone else), > >> > >> I've been reviewing the latest state of your GSoC project today, and I= 'm > >> impressed with your implementation so far. I've outlined some feedback > >> below, but I'd also like to invite everyone else on this mailing list = to > >> review your plugin. There are only approximately two weeks of GSoC lef= t. > >> > >> 1. Add the embed plugin to requirements-dev.txt on your branch so that > it > >> gets installed automatically in dev installations. > >> > > > > I just added the plugin to the requirements-dev.txt file. > > > > > >> > >> 2. The embed buttons across the UI should only appear when the plugin = is > >> enabled (currently they're always shown). > >> > > > > How can I achieve this? I'm not sure where exactly to look for examples= . > > You can check the plugin state using the trac.config functionality. > An example of usage for the bloodhound_relations plugin can be found > in the BloodhoundTheme.post_process_request(). The code checks whether > the plugin is enabled and passes the value ('bhrelations') to the > template, e.g. bh_ticket.html. The template then decides whether the > relations will be displayed or not. > > > > > > >> > >> 3. I think the embed results would benefit from some more active > styling. > >> I've created ticket #659 [1] to make a suggestion for how this could > look. > >> > > > > That's true, however I wasn't sure what would be a good appearance for > > them. But, as you said, we'll probably receive some suggestions in tick= et > > #659 (and we'll also have the mockup you mentioned in this ticket). > > > > > >> > >> Have you got any work you know is outstanding? What's the status of yo= ur > >> documentation, tests, etc? > >> > > > > I'll check again everything today and see if there are details that nee= d > to > > be worked on. > > Regarding the documentation, is there any code documentation pattern > that I > > should follow? > > For testing, Olemis suggested writing unit tests for the views. However= I > > couldn't find any relevant example I could follow. > > > > > >> > >> Many thanks for your hard work so far. > >> > > > > Thank you, I enjoyed working on it and it helped me learn new concepts. > > > > > >> > >> Joe > >> > >> -- > >> Joachim Dreimann | *User Experience Manager* > >> > >> WANdisco // *Non-Stop Data* > >> > >> e. joachim.dreimann@wandisco.com > >> twitter @jdreimann > >> > > --047d7b15b2fdd5387d04e686161d--