buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Assaf Arkin" <ar...@intalio.com>
Subject Re: svn commit: r698285 - /incubator/buildr/trunk/spec/java/bdd_spec.rb
Date Wed, 24 Sep 2008 02:18:53 GMT
On Tue, Sep 23, 2008 at 4:01 PM, Victor Hugo Borja <vic.borja@gmail.com> wrote:
> On Tue, Sep 23, 2008 at 4:55 PM, Assaf Arkin <arkin@intalio.com> wrote:
>
>> Just an observation, this:
>>     write _(:source, :spec, :java, 'Something.java'), 'public class
>> Something {}'
>> is harder to read than this:
>>    write _('src/spec/java/'Something.java'), 'public class Something {}'
>>
>> The second is also a better test case than the first, since that's how
>> we expect people to write buildfiles, so if the layout is messed the
>> first test case will ignore the bug, but the second one will catch it.
>>
>
> I've fixed this in trunk, thanks for your reviewing and your comments :)

You're welcome.

>
> --
> vic
>
> Quaerendo invenietis.
>

Mime
View raw message