buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Victor Hugo Borja" <vic.bo...@gmail.com>
Subject Re: svn commit: r698285 - /incubator/buildr/trunk/spec/java/bdd_spec.rb
Date Tue, 23 Sep 2008 23:01:56 GMT
On Tue, Sep 23, 2008 at 4:55 PM, Assaf Arkin <arkin@intalio.com> wrote:

> Just an observation, this:
>     write _(:source, :spec, :java, 'Something.java'), 'public class
> Something {}'
> is harder to read than this:
>    write _('src/spec/java/'Something.java'), 'public class Something {}'
>
> The second is also a better test case than the first, since that's how
> we expect people to write buildfiles, so if the layout is messed the
> first test case will ignore the bug, but the second one will catch it.
>

I've fixed this in trunk, thanks for your reviewing and your comments :)

-- 
vic

Quaerendo invenietis.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message