buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eung-ju Park" <eun...@gmail.com>
Subject Re: Current Rakefile is broken
Date Fri, 19 Sep 2008 13:51:53 GMT
I have investigated changes of rake 0.8.2. Behavior of
Rake::Application#have_rakefile was changed.

Below patch would be helpful to build buildr with rake 0.8.2.

Index: lib/buildr/core/application.rb
===================================================================
--- lib/buildr/core/application.rb      (revision 697069)
+++ lib/buildr/core/application.rb      (working copy)
@@ -225,10 +225,20 @@
       @gems = installed
     end

+    # In rake 0.8.2 have_rakefile returns location of rakefile. It doesn't
set @rakefile
+    def have_buildfile
+      location_or_boolean = have_rakefile
+      if location_or_boolean.kind_of? String
+        @rakefile = location_or_boolean
+        return !@rakefile.nil?
+      end
+      location_or_boolean
+    end
+
     def find_buildfile
       here = original_dir
       Dir.chdir(here) unless Dir.pwd == here
-      while ! have_rakefile
+      while ! have_buildfile
         Dir.chdir('..')
         if Dir.pwd == here || options.nosearch
           error = "No Buildfile found (looking for: #{@rakefiles.join(',
')})"


On Sun, Sep 14, 2008 at 2:11 AM, lacton <lacton@users.sourceforge.net>wrote:

> On Sat, Sep 13, 2008 at 6:58 PM, Eung-ju Park <eungju@gmail.com> wrote:
> > I guess two changes makes buildr can't work with rake 0.8.2.
> >
> > 1.
> >
> http://github.com/jimweirich/rake/commit/68303da1aeda78533c044f2a01a99a619fdb1932Prerequisites
> > are no longer FileLists
> >
> > 2.
> >
> http://github.com/jimweirich/rake/commit/41a334b4e6bd3175202675ad289668f457ef73a9Applied
> > optparse patch
> > Buildr::Application extends Rake::Application. In rake 0.8.2,
> command-line
> > argument parsing has changed. So there is some mismatch.
>
> Thanks for the information.  It looks like migrating buildr to rake
> 0.8.2 will take some time.
>
> Lacton
>



-- 
* LukeSkywalker: Is the dark side stronger?
* MasterYoda: No...no...no. Quicker, easier, more seductive.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message