buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tammo van Lessen <tvanles...@gmail.com>
Subject Re: [VOTE] Buildr 1.4.8 release
Date Thu, 01 Nov 2012 13:13:08 GMT
Hi,

awesome, this works like a charm. Thanks for fixing!

I also noticed that
http://people.apache.org/~donaldp/buildr/1.4.8/site/ does not include
the updated changelog.

Looking forward to the new release, a (non-binding) +1 from me.

Thanks for your work!
  Tammo

On Thu, Nov 1, 2012 at 1:34 PM, Peter Donald <peter@realityforge.org> wrote:
> Hi,
>
> It looks like the easiest option is to downgrade the library across the
> board until we can fix it on windows. So I have made the change and
> re-upped the release.
>
>
>
> On Thu, Nov 1, 2012 at 11:17 PM, Tammo van Lessen <tvanlessen@gmail.com>wrote:
>
>> Hi Peter,
>>
>> thanks for fixing it. While the verbose fileutils output is gone now,
>> the buildr gem is still fetching, installing and requiring the *.15
>> version of highline under JRuby and thus still does not work as
>> expected. This is because $platform is 'java' on JRuby on Win7.
>> Perhaps you could use something like the following instead.
>>
>> require 'rbconfig'
>> /mswin|mingw/.match RbConfig::CONFIG['host_os']
>>
>> I didn't provide a patch for that because I'm not entirely sure where
>> this information should be used as well (there are other deps to be
>> only included on windows, but I'm not sure if they would work with
>> JRuby).
>>
>> Thanks,
>>   Tammo
>>
>>
>> On Thu, Nov 1, 2012 at 9:53 AM, Peter Donald <peter@realityforge.org>
>> wrote:
>> > Hi,
>> >
>> > I identified and fixed the problems that you reported. Both are
>> > unfortunately in some of our dependencies. I have fixed the problems are
>> > re-uploaded the release proposal. If you could try the current version at
>> > [1] to verify the fixes, it would be much appreciated.
>> >
>> > [1] http://people.apache.org/~donaldp/buildr/1.4.8/dist/
>> >
>> > Thanks!
>> >
>> > Peter Donald
>> >
>> >
>> > On Thu, Nov 1, 2012 at 12:42 AM, Tammo van Lessen <tvanlessen@gmail.com
>> >wrote:
>> >
>> >> Hi,
>> >>
>> >> I'm perhaps to late, I haven't seen the thread earlier. I just tried
>> >> the new build on win7 and discovered two issues:
>> >>
>> >> First, the verbosity level for FileUtils seems still odd:
>> >>
>> >> C:\Users\vanto\dev\buildr-test\multi-java>buildr --version
>> >> Buildr 1.4.8 (JRuby 1.6.8)
>> >>
>> >> C:\Users\vanto\dev\buildr-test\multi-java>buildr clean
>> >> (in C:/Users/vanto/dev/buildr-test/multi-java, development)
>> >> Cleaning multi-java
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/api/target
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/api/reports
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/api/reports
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/impl/target
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/impl/reports
>> >> rm -rf
>> C:/Users/vanto/dev/buildr-test/multi-java/impl/target/test/classes
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/impl/reports/junit
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/target
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/reports
>> >> rm -rf C:/Users/vanto/dev/buildr-test/multi-java/reports
>> >> rm -rf reports/junit
>> >> Completed in 0.045s
>> >>
>> >> IMO these commands should not be logged.
>> >>
>> >> Second, when I run buildr in an empty directory, the prompt to create
>> >> a new buildfile has some issues:
>> >>
>> >> C:\Users\vanto\dev\buildr-talk>buildr
>> >> Ignored
>> >>
>> >> when I then hit enter, Buildr appends the following line:
>> >> Ambiguous choice.  Please choose one of ["1", "2", "3", "From eclipse
>> >> .project files", "From directory structure", "Cancel"].
>> >>
>> >> I'm testing with jruby 1.6.8 (ruby-1.8.7-p357) (2012-09-18 1772b40)
>> >> (Java HotSpot(TM) Client VM 1.7.0_03) [Windows 7-x86-java]
>> >>
>> >> I didn't find the time to look into these issues, perhaps you have some
>> >> ideas?
>> >>
>> >> Thanks,
>> >>   Tammo
>> >>
>> >>
>>
>>
>>
>> --
>> Tammo van Lessen - http://www.taval.de
>>
>
>
>
> --
> Cheers,
>
> Peter Donald



-- 
Tammo van Lessen - http://www.taval.de

Mime
View raw message