buildr-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mat Schaffer <...@schaffer.me>
Subject Re: Generating eclipse files for non-maven dependencies
Date Tue, 15 Sep 2009 00:17:31 GMT
Right on. I didn't notice the write function. It's that Buildr.write?  
I see a handful of "def write"s in the project.

Thanks for the credit. Looking forward to the next release.
-Mat

On Sep 14, 2009, at 6:24 PM, Alex Boisvert wrote:

> Hi Mat,
>
> I reworked your patch and applied the fix.
>
> https://issues.apache.org/jira/browse/BUILDR-315
>
> thanks!
> alex
>
>
> On Mon, Sep 14, 2009 at 8:20 AM, Mat Schaffer <mat@schaffer.me> wrote:
>
>>
>> On Sep 14, 2009, at 10:47 AM, Mat Schaffer wrote:
>>
>>
>>> On Sep 14, 2009, at 1:14 AM, Alex Boisvert wrote:
>>>
>>>> 'generated' refers to classes that may be generated from source  
>>>> (e.g.
>>>> xmlbeans) prior to compilation.
>>>>
>>>> checking for .jar (your prior patch) or checking for a file (your  
>>>> new
>>>> file) seem to be equivalent and both are better, as far as I can  
>>>> tell.
>>>>
>>>> if you want to clean this up and submit a patch, i'll be happy to  
>>>> apply
>>>> it.   i'll add a spec for the generated case at the same time.
>>>>
>>>> thanks for your persistence... i should have picked up on this  
>>>> earlier.
>>>>
>>>> alex
>>>>
>>>
>>> Thanks for getting back to me, Alex. I've attached the patch for  
>>> what I
>>> have so far, but I'm not thrilled about the file system access.  
>>> I'll see
>>> what I can come up with in terms of mocking but I thought I'd put  
>>> this out
>>> there to see if you had any feedback on that front.
>>> -Mat
>>>
>>> <eclipse_local_lib.patch>
>>>
>>
>> Spoke too soon. Here's a patch using rspec's mocking features. If  
>> you have
>> any thoughts on how to make it cleaner, let me know, but I'm pretty  
>> happy
>> with it.
>>
>>
>>
>>
>> Thanks,
>> Mat
>>


Mime
View raw message