buildr-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mat Schaffer <...@schaffer.me>
Subject Re: Generating eclipse files for non-maven dependencies
Date Mon, 14 Sep 2009 15:20:04 GMT

On Sep 14, 2009, at 10:47 AM, Mat Schaffer wrote:

>
> On Sep 14, 2009, at 1:14 AM, Alex Boisvert wrote:
>> 'generated' refers to classes that may be generated from source  
>> (e.g. xmlbeans) prior to compilation.
>>
>> checking for .jar (your prior patch) or checking for a file (your  
>> new file) seem to be equivalent and both are better, as far as I  
>> can tell.
>>
>> if you want to clean this up and submit a patch, i'll be happy to  
>> apply it.   i'll add a spec for the generated case at the same time.
>>
>> thanks for your persistence... i should have picked up on this  
>> earlier.
>>
>> alex
>
> Thanks for getting back to me, Alex. I've attached the patch for  
> what I have so far, but I'm not thrilled about the file system  
> access. I'll see what I can come up with in terms of mocking but I  
> thought I'd put this out there to see if you had any feedback on  
> that front.
> -Mat
>
> <eclipse_local_lib.patch>

Spoke too soon. Here's a patch using rspec's mocking features. If you  
have any thoughts on how to make it cleaner, let me know, but I'm  
pretty happy with it.


Mime
View raw message