bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlos Vara (JIRA)" <j...@apache.org>
Subject [jira] Commented: (BVAL-45) ValidationException must be thrown when validating a bean with an annotated method which isn't a valid getter
Date Mon, 17 May 2010 13:33:42 GMT

    [ https://issues.apache.org/jira/browse/BVAL-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868218#action_12868218
] 

Carlos Vara commented on BVAL-45:
---------------------------------

I'm currently cleaning the code of a big patch that solves group sequence processing for when
this is merged/discarded :-)

> ValidationException must be thrown when validating a bean with an annotated method which
isn't a valid getter
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-45
>                 URL: https://issues.apache.org/jira/browse/BVAL-45
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>         Attachments: bval-jsr303-45.patch
>
>
> This one has its problems because it clashes directly with the MethodValidation implementation.
I provide a candidate patch that follows the spec and doesn't break our extra functionality,
please review it.
> Supplied patch:
> - Forces correct behavior of bean validation according to the spec: that is, a ValidationException
is thrown. So, if you want to validate a bean which also has an annotated method, the implementation
will follow the spec and throw an exception.
> - Method validation works, but it is slower than before as constraint descriptions are
no longer cached. This can be fixed, I just left this for later as I prefer to concentrate
in TCK tests and I also would like to gather opinions as if this is the correct route or you
have a better idea for this.
> - 1 more TCK test passes.
> So, to sum it up, if this patch is merged, don't mix annotated fields/getters with annotated
methods in the same class. On the bright side, constructor annotations can be mixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message