bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlos Vara (JIRA)" <j...@apache.org>
Subject [jira] Commented: (BVAL-63) use java.util.ServiceLoader in DefaultValidationProviderResolver#getValidationProviders()
Date Wed, 26 May 2010 09:48:34 GMT

    [ https://issues.apache.org/jira/browse/BVAL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871595#action_12871595
] 

Carlos Vara commented on BVAL-63:
---------------------------------

I think I solved it. TCK fails (and probably our impl too, as they use a similar algorithm
while loading) if an empty line is present in the SPI file.

> use java.util.ServiceLoader in DefaultValidationProviderResolver#getValidationProviders()
> -----------------------------------------------------------------------------------------
>
>                 Key: BVAL-63
>                 URL: https://issues.apache.org/jira/browse/BVAL-63
>             Project: BeanValidation
>          Issue Type: Bug
>    Affects Versions: 0.1-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.2-incubating
>
>
> 4.4.4.1
> > By default, providers are resolved using the Service Provider pattern described
in
> > http://java.sun.com/j2se/1.5.0/docs/guide/jar/jar.html#Service%20Provider. Bean
Validation providers must supply a
> > service provider configuration file by creating a text file javax.validation.spi.ValidationProvider
and placing
> > it in the META-INF/services directory of one of its jar files. The content of the
file should contain the name of the
> > provider implementation class of the javax.validation.spi.ValidationProvider interface.
> But we internally currently dont use the java.util.ServiceLoader but do a
> cl.getResources(SPI_CFG);
> instead in DefaultValidationProviderResolver#getValidationProviders()
> This is imo a bug in our impl!
> See here for how to use the ServiceLoader mechanism properly:
> https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/plugins/PluginLoader.java


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message