bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: Some changes
Date Fri, 10 Oct 2014 06:21:45 GMT
Hi Daniel,

can you describe the change and the goal please?

Personally I don't like that much creating new instances here, it will
add an overhead we don't want, static methods would work as well but
not sure I follow the final goal. I wrote this so of course I was
happy this existing version but with your change I find the code
indirected and harder to follow. If you find some methods too long
maybe just create few more?



Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau


2014-10-10 2:48 GMT+02:00 Daniel Cunha <danielsoro@gmail.com>:
> Hi folks,
>
> I made some changes in the BValInterceptor
>
> Let me know if you like this change:
> https://github.com/danielsoro/bval/commit/8080e76d40b03bd43fd30685f39a5312c14a8881
>
> --
> Daniel Cunha (soro) <http://www.cejug.net>
> Blog: http://www.danielsoro.com.br
> Twitter: https://twitter.com/dvlc_
> GitHub: https://github.com/danielsoro
> LinkedIn:  http://www.linkedin.com/in/danielvlcunha

Mime
View raw message