bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BVAL-167) ConstraintDeclarationException: Illegal strengthening: overridden [constraints] in inheritance hierarchy
Date Mon, 05 Nov 2018 07:46:00 GMT

    [ https://issues.apache.org/jira/browse/BVAL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674761#comment-16674761
] 

Romain Manni-Bucau edited comment on BVAL-167 at 11/5/18 7:45 AM:
------------------------------------------------------------------

[~ilgrosso] the rule says that children must not be weaker in terms of constraints than the
parent so if the parent is @NotNull the children must be as well. So if you add @NotNull in
the whole inheritance tree it will pass.

{code}
    // in both the abstract and leaf implementation I think cause of the broken inheritance
    @Override
    public AttrTO read(@NotNull final String key, @NotNull final SchemaType schemaType, @NotNull
final String schema) {
{code}


was (Author: romain.manni-bucau):
[~ilgrosso] the rule says that children must not be weaker in terms of constraints than the
parent so if the parent is @NotNull the children must be as well. So if you add @NotNull in
the whole inheritance tree it will pass.

{code}
    @Override
    public AttrTO read(@NotNull final String key, @NotNull final SchemaType schemaType, @NotNull
final String schema) {
{code}

> ConstraintDeclarationException: Illegal strengthening: overridden [constraints] in inheritance
hierarchy
> --------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-167
>                 URL: https://issues.apache.org/jira/browse/BVAL-167
>             Project: BVal
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Francesco Chicchiriccò
>            Priority: Major
>             Fix For: 2.0.1
>
>
> I am trying to upgrade BVal to 2.0.0 in Syncope.
> I have changed my POMs as follows:
> * javax.validation:validation-api from 1.1.0.Final to 2.0.1.Final
> * org.apache.bval:bval-jsr from 1.1.2 to 2.0.0
> When I try to reach up some of the REST services (based on CXF 3.2), an [exception|https://paste.apache.org/hxvY]
is thrown; I have read about such exception, but it seems to me that the mentioned methods
in [interface|https://github.com/apache/syncope/blob/2_1_X/common/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/AnyService.java#L70]
and [implementation|https://github.com/apache/syncope/blob/2_1_X/core/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractAnyService.java#L68]
should comply with hierarchy rules.
> Nevertheless, if I swap
> org.apache.bval:bval-jsr:2.0.0
> with
> org.hibernate.validator:hibernate-validator:6.0.13.Final
> all is working fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message