bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BVAL-170) BVAL 2.x is very very slow
Date Sat, 16 Feb 2019 19:44:00 GMT

    [ https://issues.apache.org/jira/browse/BVAL-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770180#comment-16770180
] 

Matt Benson commented on BVAL-170:
----------------------------------

[~tandraschko]: thanks and sorry for the slow response. I wonder if you also noticed that
I had made some other commits, mostly based on [~rmannibucau]'s suggestions... are these
accounted for in your new numbers? Your second patch applies fine and I will be committing
it with one change: the reason for the `new ArrayList()` where you modified `PathNavigation`
was to detach the ongoing use of that object from the array, which could be subsequently modified.
I added a call to `clone()` the array which will hopefully still be more performant than the
new List.

WRT the second patch, the first hunk is easy enough to see what's going on, but the rest of
it appears as whole-file modifications so I am not easily able to tell what changes you're
suggesting. Could you recreate that patch with more granularity?

Thanks,

Matt

> BVAL 2.x is very very slow
> --------------------------
>
>                 Key: BVAL-170
>                 URL: https://issues.apache.org/jira/browse/BVAL-170
>             Project: BVal
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 1.1.2, 2.0.0
>            Reporter: Thomas Andraschko
>            Priority: Critical
>         Attachments: bval1.patch, bval2.patch
>
>
> Simple case:
> [https://gist.github.com/tandraschko/160195cfd35c22d8519a4304856fab65]
> With BVal it takes on my machine around 20 seconds.
> Hibernate Validator 6 takes around 1 second.
> I also checked the hibernate validator benchmark for a case and here is a extract of
one case with operations per seconds:
> HV 6: 874
> BV 1.1: 347
> BV 2.0: 53



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message