bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Andraschko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BVAL-170) BVAL 2.x is very very slow
Date Sat, 16 Feb 2019 20:48:00 GMT

    [ https://issues.apache.org/jira/browse/BVAL-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770209#comment-16770209
] 

Thomas Andraschko edited comment on BVAL-170 at 2/16/19 8:47 PM:
-----------------------------------------------------------------

[~mbenson] thanks matt! i didn't benchmark all single commits but with this patch now, i got
~1500ms on my machine, compared to ~500ms from hv. please review it!

we should really try to get below 1000ms (2x as slow as hibernate).

 

i dont want to critism a specific programming style but i think many of the Optional instances
can be replaced with simple null checks. better for memory and maybe a small bit for performance.
not sure if its worth.

 


was (Author: tandraschko):
[~mbenson] thanks matt! i didn't benchmark all single commits but with this patch now, i got
~1500ms on my machine, compared to ~500ms from hv. please review it!

we should really try to get below 1000ms.

 

> BVAL 2.x is very very slow
> --------------------------
>
>                 Key: BVAL-170
>                 URL: https://issues.apache.org/jira/browse/BVAL-170
>             Project: BVal
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 1.1.2, 2.0.0
>            Reporter: Thomas Andraschko
>            Priority: Critical
>         Attachments: bval1.patch, bval2.patch, bval3.patch
>
>
> Simple case:
> [https://gist.github.com/tandraschko/160195cfd35c22d8519a4304856fab65]
> With BVal it takes on my machine around 20 seconds.
> Hibernate Validator 6 takes around 1 second.
> I also checked the hibernate validator benchmark for a case and here is a extract of
one case with operations per seconds:
> HV 6: 874
> BV 1.1: 347
> BV 2.0: 53



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message