bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BVAL-171) Compatibility with hv benchmark
Date Tue, 26 Feb 2019 18:06:00 GMT

    [ https://issues.apache.org/jira/browse/BVAL-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778420#comment-16778420
] 

Matt Benson edited comment on BVAL-171 at 2/26/19 6:05 PM:
-----------------------------------------------------------

Are you saying that we are failing to respect the {{include-existing-validators}} specifications
in their custom mapping file? Or that we somewhere enforce that the first type parameter of
the validator class is the actual constraint annotation type as opposed to `Annotation`?


was (Author: mbenson):
Are you saying that we are failing to respect the {{include-existing-validators}} specifications
in their custom mapping file?

> Compatibility with hv benchmark
> -------------------------------
>
>                 Key: BVAL-171
>                 URL: https://issues.apache.org/jira/browse/BVAL-171
>             Project: BVal
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Thomas Andraschko
>            Priority: Major
>             Fix For: 2.0.1
>
>
> AFAICS a validator can be reused via mapping for multiple constraints:
> [https://github.com/hibernate/hibernate-validator/blob/master/performance/src/main/resources/org/hibernate/validator/performance/statistical/mapping.xml]
> [https://github.com/hibernate/hibernate-validator/blob/master/performance/src/main/java/org/hibernate/validator/performance/statistical/StatisticalConstraintValidator.java]
>  
> bval 2.x doesnt allow this but 1.x does.
>  
> I think the fix is really simple and just a "validation" thing, would be great if someone
could check it. I can't use my right hand the next ~2 weeks (thanks to my mountainbike...)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message