bval-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BVAL-175) Regression in "Design by Contract" example
Date Fri, 17 May 2019 09:53:00 GMT

    [ https://issues.apache.org/jira/browse/BVAL-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842049#comment-16842049
] 

Romain Manni-Bucau commented on BVAL-175:
-----------------------------------------

Hi David,

AFAIK it is not a Bean Validation feature and the processing we had in the CDI extension is
way too complex for the user benefit. The TomEE regression comes from the fact we only check
direct method and not inheritance. Here the options I see if TomEE needs that feature:

1. TomEE can add the checks through a CDI extension quite easily,
2. BVal could get a toggle switched off by default
3. We can just say this is not a feature.

For reference the fix is as trivial as putting @ValidateOnExecute on the inherited method
which is the standard activation of Bean Validation - the example was done before this becomes
standard so didn't get it I guess.

Romain


> Regression in "Design by Contract" example
> ------------------------------------------
>
>                 Key: BVAL-175
>                 URL: https://issues.apache.org/jira/browse/BVAL-175
>             Project: BVal
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>            Reporter: David Blevins
>            Priority: Major
>
> Hi All,
> I attempted to upgrade TomEE to the latest BVal 2.0.x code and noticed one potential
regression that affects this example:
>  - https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract
> I did a git bisect to pinpoint the exact BVal commit that causes the example to fail:
> - https://github.com/apache/bval/commit/5bca3a73ae798d0671f964448b6e590d9bae396d
> Everything before that is fine.  There and after is the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message