calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Hyde <julianh...@gmail.com>
Subject Re: OPTIQ-282
Date Mon, 22 Sep 2014 18:24:11 GMT
Benoy,

Your patch looks basically good. I discovered a couple of issues, and noted them at https://github.com/apache/incubator-optiq/pull/13.
When you address these, I will commit.

Julian


On Sep 21, 2014, at 9:00 PM, Julian Hyde <julianhyde@gmail.com> wrote:

> Yes, I will review.
> 
> By the way, great to see you at the hackathon. Good to see the finished
> work coming in!
> 
> Julian
> 
> On Sun, Sep 21, 2014 at 8:25 PM, Benoy Antony <bantony@gmail.com> wrote:
> 
>> Hi All,
>> 
>> I have generated a pull request for OPTIQ-282 at
>> https://github.com/apache/incubator-optiq/pull/13
>>  Could I please get a review of the patch ?
>> 
>> 
>> thanks ,
>> Benoy
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message