calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vladimir Sitnikov <sitnikov.vladi...@gmail.com>
Subject Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)
Date Sun, 01 Feb 2015 13:00:14 GMT
+1. It compiles, and works for me.

Julian,

While your fix for 582 works, I do not like how it is implemented.

If you suggest that *ableTable should always return Object[], then you
should express that in email/ticket or at least in
org.apache.calcite.adapter.enumerable.EnumerableTableScan#format.

return ---> table.unwrap(QueryableTable.class) != null <--- &&
fieldCount == 1 ? JavaRowFormat.SCALAR : JavaRowFormat.ARRAY;

Vladimir

Mime
View raw message