calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Dunning <ted.dunn...@gmail.com>
Subject Re: Upgrade Guava
Date Tue, 10 Feb 2015 17:11:23 GMT
The general principle Jacques is espousing is that the consumer should
shade if necessary.  Hive is a consumer of Calcite.  Drill is a consumer of
Hive *and* Calcite.



On Tue, Feb 10, 2015 at 9:04 AM, Jacques Nadeau <jacques@apache.org> wrote:

> My recommendation is that the Calcite community doesn't shade.  If someone
> (such as Hive) wants to use a conflicting dependency, they can choose to
> shade Calcite (and just the portions that conflict for them).   If you want
> to see how we do this in Drill with Hive, you can look here [1]
>
> I know there was a forwards incompatibility between certain Guava versions
> (11 and 14 maybe?).  If we can pick one that is forward compatible.  (E.g.
> Calcite supports 14 - 18), that would be ideal.  However, I'm not sure
> Guava publishes anything like this.  As such, I suggest we just pick what
> makes sense and people can shade if they need to.
>
> [1]
>
> https://github.com/apache/drill/blob/master/contrib/storage-hive/hive-exec-shade/pom.xml
>
>
> On Tue, Feb 10, 2015 at 8:12 AM, Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
> > Am I right you suggest to shade just Guava?
> > maven-shade-plugin has a nasty side-effect of "rewriting destination
> > jar", thus it disturbs incremental build/compilation
> >
> > Vladimir
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message