calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Hyde <julianh...@gmail.com>
Subject Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)
Date Sun, 01 Feb 2015 16:29:15 GMT
Agreed. I needed to fix the bug and get a release out with the minimum
of disruption. There is an opportunity to do better as part of
https://issues.apache.org/jira/browse/CALCITE-558. Please get involved
in that.

Julian

On Sun, Feb 1, 2015 at 5:00 AM, Vladimir Sitnikov
<sitnikov.vladimir@gmail.com> wrote:
> +1. It compiles, and works for me.
>
> Julian,
>
> While your fix for 582 works, I do not like how it is implemented.
>
> If you suggest that *ableTable should always return Object[], then you
> should express that in email/ticket or at least in
> org.apache.calcite.adapter.enumerable.EnumerableTableScan#format.
>
> return ---> table.unwrap(QueryableTable.class) != null <--- &&
> fieldCount == 1 ? JavaRowFormat.SCALAR : JavaRowFormat.ARRAY;
>
> Vladimir

Mime
View raw message