calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <josh.el...@gmail.com>
Subject Re: Loose ends before 1.6
Date Wed, 13 Jan 2016 04:05:28 GMT
I think we should not wait for 1050 -- I don't have a handle on how much 
work it would be. I also have not been able to reproduce 1052, so that 
one is currently out.

I'll continue to work with 1050 while the other stuff filters out. Can 
make a final decision as things progress.

Julian Hyde wrote:
> We’re making progress. Here’s what’s left before we can cut an RC:
>
> * https://issues.apache.org/jira/browse/CALCITE-1047 - Julian
> * https://issues.apache.org/jira/browse/CALCITE-1044 - Josh
> * https://issues.apache.org/jira/browse/CALCITE-1052 - Josh
> * https://issues.apache.org/jira/browse/CALCITE-1050 - Josh
> * Have we broken Phoenix? - Maryann
> * https://issues.apache.org/jira/browse/CALCITE-1047 - Jason to review, Julian to commit
>
> Josh, I know some of those were “best effort”. Let me know if you want to drop some.
>
> Have I missed anything?
>
> Is anyone planning to validate Hive or Drill against the snapshot?
>
> Julian
>
>
>> On Jan 11, 2016, at 8:50 PM, Julian Hyde<jhyde@apache.org>  wrote:
>>
>> OK, let us know what you find… this is the perfect time to find&  fix such
problems.
>>
>> You might find it useful to try against Calcite just before 816 and 794 were committed.
Those were both big changes.
>>
>> Julian
>>
>>> On Jan 11, 2016, at 7:25 PM, Maryann Xue<maryann.xue@gmail.com>  wrote:
>>>
>>> Having some problems with Calcite-Phoenix here. Still trying to identify...
>>>
>>> Thanks,
>>> Maryann
>>>
>>> On Mon, Jan 11, 2016 at 10:03 PM, Josh Elser<josh.elser@gmail.com>  wrote:
>>>
>>>> ACK'ed
>>>>
>>>> Julian Hyde wrote:
>>>>
>>>>> I just pushed 1.6.0-SNAPSHOT to Apache; it’s based on
>>>>> https://github.com/apache/calcite/commit/78973eca94e81f7ccf1f9fc792d555239faaa049
>>>>> <
>>>>> https://github.com/apache/calcite/commit/78973eca94e81f7ccf1f9fc792d555239faaa049>
>>>>> and has draft release notes at
>>>>> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md<
>>>>> https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md>.
>>>>>
>>>>> If you’re one of those projects who likes to compatibility before a
>>>>> release, please validate against that snapshot, and give us a +1 or -1.
>>>>>
>>>>> We have time for a few more issues to be fixed. Based on what I’ve
heard
>>>>> in this thread, the list is as follows:
>>>>> 1050, 1040, 1044, 1052 (Josh)
>>>>> 996 (Jesus)
>>>>> 1047, 1051, 977 (me)
>>>>>
>>>>> Josh&   Jesus, Can you let me know when you are done? A day or two,
>>>>> hopefully.
>>>>>
>>>>>
>>>>> Committers, We’re stabilizing. I don’t want to break things after
people
>>>>> have started validating against the snapshot. If you want to commit
>>>>> something that’s not on the above list, please discuss it here first.
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>>>
>>>>> On Jan 11, 2016, at 1:19 PM, Josh Elser<josh.elser@gmail.com> 
 wrote:
>>>>>> Ugh, CALCITE-1052 just came in which sounds scary (although, it might
>>>>>> just be hitting the lack of thread-safety as recently discussed --
if I
>>>>>> could directly interpret the discussion as also filtering up to Avatica).
I
>>>>>> need to investigate either way.
>>>>>>
>>>>>> Josh Elser wrote:
>>>>>>
>>>>>>> I'd like to try to get CALCITE-1040, CALCITE-1044 and (hopefully)
>>>>>>> CALCITE-1050 done.
>>>>>>>
>>>>>>> I plan to work on them today, but I don't think we need to hold
things
>>>>>>> up for any of them if everyone else is ready to go.
>>>>>>>
>>>>>>> Julian Hyde wrote:
>>>>>>>
>>>>>>>> I volunteer to be release manager for this release.
>>>>>>>>
>>>>>>>> I’ve made some progress over the weekend. 816 and 794 —
the two big
>>>>>>>> ones — are ready to submit. So we should be good to go
for an RC
>>>>>>>> tomorrow.
>>>>>>>>
>>>>>>>> I’ve even put together a first draft of the release notes:
>>>>>>>>
>>>>>>>> https://github.com/julianhyde/calcite/blob/scratch/site/_docs/history.md
>>>>>>>>
>>>>>>>> That said, there’s still time to get some last changes
in. In fact I’d
>>>>>>>> welcome it. It’s good to tidy up that long list of half-finished
>>>>>>>> tasks. Let us know if you’re working on something.
>>>>>>>>
>>>>>>>> I’ve heard Jesus and Jason say they want to try to get
items in.
>>>>>>>> Anyone else?
>>>>>>>>
>>>>>>>> Julian
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Jan 8, 2016, at 5:10 PM, Jason Altekruse<altekrusejason@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Thanks Julian, will submit them as PRs.
>>>>>>>>>
>>>>>>>>> On Fri, Jan 8, 2016 at 5:00 PM, Julian Hyde<jhyde@apache.org>
  wrote:
>>>>>>>>>
>>>>>>>>> Jason,
>>>>>>>>>> I’ve made you a contributor in JIRA and assigned
977 and 978 to you.
>>>>>>>>>> It
>>>>>>>>>> would be great if you can get those submitted. If
possible, can you
>>>>>>>>>> submit
>>>>>>>>>> PRs rather than patches.
>>>>>>>>>>
>>>>>>>>>> Julian
>>>>>>>>>>
>>>>>>>>>> On Jan 8, 2016, at 4:55 PM, Jason Altekruse<altekrusejason@gmail.com
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Jinfeng,
>>>>>>>>>>>
>>>>>>>>>>> I don't think I've contributed to Calcite since
the move to Apache,
>>>>>>>>>>> so I
>>>>>>>>>>> probably have not been added as a contributor
on JIRA (necessary
>>>>>>>>>>> for JIRA
>>>>>>>>>>> assignment I believe). Apologies for the delay
on these, I will
>>>>>>>>>>> rebase
>>>>>>>>>>>
>>>>>>>>>> the
>>>>>>>>>>
>>>>>>>>>>> patches from the Drill fork and get them submitted.
>>>>>>>>>>>
>>>>>>>>>>> - Jason
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Jan 7, 2016 at 10:24 PM, Hsuan Yi Chu<hyichu@maprtech.com>
>>>>>>>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Julian,
>>>>>>>>>>>> The issue in Calcite-928 was resolved in
Calcite-922's pull
>>>>>>>>>>>> request.
>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-922
>>>>>>>>>>>> I just marked it as resolved.
>>>>>>>>>>>>
>>>>>>>>>>>> The issue in Calcite-900 seems specific in
Drill side and until
>>>>>>>>>>>> now I
>>>>>>>>>>>>
>>>>>>>>>>> could
>>>>>>>>>>> not reproduce within Calcite.
>>>>>>>>>>>> Would it make sense to mark it as invalid?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Jan 7, 2016 at 5:14 PM, Jinfeng Ni<jinfengni99@gmail.com>
>>>>>>>>>>>>
>>>>>>>>>>> wrote:
>>>>>>>>>>> Hi Julian,
>>>>>>>>>>>>> I'll submit a PR for CALCITE-975, and
maybe CALCITE-976 which
>>>>>>>>>>>>> comes
>>>>>>>>>>>>> from Mehant.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Could you please assign CALCITE-978 and
CALCITE-977 to Jason
>>>>>>>>>>>>> Altekruse? Those patches actually came
from him, and for some
>>>>>>>>>>>>> reason,
>>>>>>>>>>>>> I could not assign Calcite JIRA to him.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Jinfeng
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Jan 7, 2016 at 4:52 PM, Julian
Hyde<jhyde@apache.org>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> There are a few pull requests and
JIRA cases that have been
>>>>>>>>>>>>>> started
>>>>>>>>>>>>>>
>>>>>>>>>>>>> but
>>>>>>>>>>> not finished. Can you look for your name below,
and give an
>>>>>>>>>>>>> update on
>>>>>>>>>>>>>
>>>>>>>>>>>> them?
>>>>>>>>>>>>
>>>>>>>>>>>>> Can we get them finished for 1.6?
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Pull requests with input needed from
author:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> * Tom Barber: https://github.com/apache/calcite/pull/162
>>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-944
>>>>>>>>>>>>>
>>>>>>>>>>>>>> * Julien https://github.com/apache/calcite/pull/168
>>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-991
>>>>>>>>>>>>>
>>>>>>>>>>>>>> * Jesus https://github.com/apache/calcite/pull/171
>>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-996
>>>>>>>>>>>>>
>>>>>>>>>>>>>> * Vladimir https://github.com/apache/calcite/pull/176
>>>>>>>>>>>>>> * Zinking https://github.com/apache/calcite/pull/178
>>>>>>>>>>>>>> * Philip Rhodes https://github.com/apache/calcite/pull/180
>>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-1025
>>>>>>>>>>>>>
>>>>>>>>>>>>>> JIRA cases:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> * me https://issues.apache.org/jira/browse/CALCITE-1046
>>>>>>>>>>>>>> * Ted Xu https://issues.apache.org/jira/browse/CALCITE-1043
>>>>>>>>>>>>>> * Alexey Makhmutov
>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-1037
>>>>>>>>>>>>>> * me https://issues.apache.org/jira/browse/CALCITE-1036
>>>>>>>>>>>>>> * Jinfeng https://issues.apache.org/jira/browse/CALCITE-978
>>>>>>>>>>>>>> * Jinfeng https://issues.apache.org/jira/browse/CALCITE-977
>>>>>>>>>>>>>> * Jinfeng https://issues.apache.org/jira/browse/CALCITE-976
>>>>>>>>>>>>>> * Jinfeng https://issues.apache.org/jira/browse/CALCITE-975
>>>>>>>>>>>>>> * Kevin Liew https://issues.apache.org/jira/browse/CALCITE-972
>>>>>>>>>>>>>> * Julien https://issues.apache.org/jira/browse/CALCITE-957
>>>>>>>>>>>>>> * Jacques https://issues.apache.org/jira/browse/CALCITE-950
>>>>>>>>>>>>>> * Sean https://issues.apache.org/jira/browse/CALCITE-928
>>>>>>>>>>>>>> * Sean https://issues.apache.org/jira/browse/CALCITE-900
>>>>>>>>>>>>>> * Jesus https://issues.apache.org/jira/browse/CALCITE-742
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ready to review by any committer:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1020
>>>>>>>>>>>>>> * https://github.com/apache/calcite/pull/178
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Fix on the way:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1042
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1041
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1039
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1038
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-1036
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-955
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-915
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-854
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-816
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-794
>>>>>>>>>>>>>> * https://issues.apache.org/jira/browse/CALCITE-790
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Completed PRs to be closed: 108,
174
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Julian
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>
>

Mime
View raw message