calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinfeng Ni <...@apache.org>
Subject Assertion check in RelOptTableImpl.create()
Date Fri, 08 Jan 2016 01:40:20 GMT
Does anyone know why one of the static create() methods in
RelOptTableImpl has the following assertion check (to check table is
instance of TranslatableTable, or ScannableTable, or ModifiableTable)
[1], while the rest of create() methods do not do such check? [2]

Looks like RelOptTableImpl.toRel() actually expects table instance
other than the above three class[3].

Does it makes sense to remove the assertion check in [1]?

Best Regards,

Jinfeng


[1]. https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/RelOptTableImpl.java#L167-L169

[2] https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/RelOptTableImpl.java#L118

[3] https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/RelOptTableImpl.java#L225

Mime
View raw message