calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jark Wu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CALCITE-1461) Hard code in JaninoRelMetadataProvider makes shading for Calcite failed
Date Sat, 22 Oct 2016 09:15:58 GMT
Jark Wu created CALCITE-1461:
--------------------------------

             Summary: Hard code in JaninoRelMetadataProvider makes shading for Calcite failed
                 Key: CALCITE-1461
                 URL: https://issues.apache.org/jira/browse/CALCITE-1461
             Project: Calcite
          Issue Type: Bug
            Reporter: Jark Wu
            Assignee: Julian Hyde
             Fix For: 1.9.0


In {{JaninoRelMetadataProvider.load3}}, the generated class string contains some hard coded
Calcite's classes, such as {{org.apache.calcite.rel.metadata.MetadataDef}}. After shading
Calcite, the MetadataDef can not be found in the shaded classes. And a compile error will
be thrown.

So it's better to use {{MetadataDef.class.getName()}} to replace the hard code string.

I'm appreciate to make a PR if you want. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message