calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CALCITE-1654) Serialized messages are generated even though they are not logged
Date Wed, 22 Feb 2017 18:49:44 GMT
Josh Elser created CALCITE-1654:
-----------------------------------

             Summary: Serialized messages are generated even though they are not logged
                 Key: CALCITE-1654
                 URL: https://issues.apache.org/jira/browse/CALCITE-1654
             Project: Calcite
          Issue Type: Bug
          Components: avatica
            Reporter: Sergey Soldatov
            Assignee: Josh Elser
            Priority: Critical
             Fix For: avatica-1.10.0


[~sergey.soldatov] made a good find through some careful log reading.

In ProtobufTranslationImpl, some TRACE logging that I had added in CALCITE-1159 is causing
a bunch of garbage to be created on the heap.

The trace logging messages should be wrapped in a conditionals to avoid the generation of
the message itself. I was a little too overzealous thinking that the slf4j api was saving
me.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message