calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CALCITE-1661) Recognize aggregation function types as FRACTIONAL instead of DOUBLE
Date Mon, 27 Feb 2017 09:47:45 GMT
Jesus Camacho Rodriguez created CALCITE-1661:
------------------------------------------------

             Summary: Recognize aggregation function types as FRACTIONAL instead of DOUBLE
                 Key: CALCITE-1661
                 URL: https://issues.apache.org/jira/browse/CALCITE-1661
             Project: Calcite
          Issue Type: Bug
          Components: druid
    Affects Versions: 1.12.0
            Reporter: Jesus Camacho Rodriguez
            Assignee: Jesus Camacho Rodriguez
             Fix For: 1.12.0


Currently, whether to use fractional or integer aggregations is based on following code (L699
in DruidQuery.java).

{code}
final boolean b = aggCall.getType().getSqlTypeName() == SqlTypeName.DOUBLE;
{code}

Since Hive might use other fractional types for the aggregation, we might end up using the
wrong type of aggregation in Druid. We could extend the check as follows:

{code}
final boolean b = SqlTypeName.FRACTIONAL_TYPES.contains(aggCall.getType().getSqlTypeName());
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message